Add watch permissions on rke_logreader_t:var_log_t:dir context #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mallardduck
suggested changes
May 22, 2025
There was a problem hiding this comment.
O&B was asked to triage the JIRA associated with this, so just giving it a look over.
However I think @andypitcher (or someone else from Rancher Security) is probably best for final review since their team owns this repo, my team just maintains the Logging chart this particular issue is related to.
andypitcher
approved these changes
May 27, 2025
There was a problem hiding this comment.
@philippebi @mallardduck thanks for your inputs, this LGTM. I'm working on another PR to get the pipeline fixed, then we can likely merge this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[SURE-10202]
#72 Add missing 'watch permissions